gtk4.git
8 years agoaccellabel: Fix code snippet
Timm Bäder [Wed, 11 Oct 2017 10:56:42 +0000 (12:56 +0200)]
accellabel: Fix code snippet

8 years agoaboutdialog: Fix code snippets
Timm Bäder [Wed, 11 Oct 2017 10:55:01 +0000 (12:55 +0200)]
aboutdialog: Fix code snippets

Define all variables and fix a missing comma in the first
gtk_show_about_dialog call.

8 years agoapplicationwindow: Fix code sample
Timm Bäder [Wed, 11 Oct 2017 10:41:47 +0000 (12:41 +0200)]
applicationwindow: Fix code sample

Declare all variables, use proper GtkApplication constructor and the
right GTK_APPLICATION() cast for gtk_application* API.

8 years agotogglebutton: Fix code snippet
Timm Bäder [Wed, 11 Oct 2017 10:35:55 +0000 (12:35 +0200)]
togglebutton: Fix code snippet

Remove gtk_box_pack_start usage, gtk_dialog_get_content_area, fix wrong
gtk_dialog_new parameters and actually add a output_state callback.

8 years agogtksettings: Fix code snippet
Timm Bäder [Wed, 11 Oct 2017 10:21:20 +0000 (12:21 +0200)]
gtksettings: Fix code snippet

gtk_init does not take any arguments anymore and
GTK_TYPE_IMAGE_MENU_ITEM is gone.

8 years agolabel: Make all code snippets properly compile
Timm Bäder [Wed, 11 Oct 2017 10:18:22 +0000 (12:18 +0200)]
label: Make all code snippets properly compile

8 years agoaccellabel: Document new API
Timm Bäder [Wed, 11 Oct 2017 09:08:46 +0000 (11:08 +0200)]
accellabel: Document new API

8 years agoconview: Fix rubberband coordinates when scrolling
Timm Bäder [Wed, 11 Oct 2017 08:55:20 +0000 (10:55 +0200)]
conview: Fix rubberband coordinates when scrolling

8 years agoiconview: Remove double-MAX when updating rubberband
Timm Bäder [Wed, 11 Oct 2017 08:50:03 +0000 (10:50 +0200)]
iconview: Remove double-MAX when updating rubberband

8 years agorendericon: Fix texture transformation
Timm Bäder [Wed, 11 Oct 2017 07:24:35 +0000 (09:24 +0200)]
rendericon: Fix texture transformation

Use the one from snapshot_icon, which works.

8 years agomodelmenuitem: Fix icon/label alignment
Timm Bäder [Wed, 11 Oct 2017 07:03:40 +0000 (09:03 +0200)]
modelmenuitem: Fix icon/label alignment

gtk_box_pack_end will put the label child at the right side of the label
(in LTR orientation), but we want it left, directly next to the icon.
Also remove the spacing from the box child as this is a theme thing.

8 years agogrid: Only pass baselines to children that request it
Timm Bäder [Wed, 11 Oct 2017 06:49:44 +0000 (08:49 +0200)]
grid: Only pass baselines to children that request it

8 years agogrid: Simplify allocating children
Timm Bäder [Wed, 11 Oct 2017 06:25:20 +0000 (08:25 +0200)]
grid: Simplify allocating children

allocation->x and allocation->y are always 0. MAX'ing width/height with
1 is also wrong now since 0 is a valid width/height for widgets.

8 years agoeventcontrollerscroll: Emit ::scroll for -1/+1 discrete steps
Timm Bäder [Wed, 11 Oct 2017 06:06:33 +0000 (08:06 +0200)]
eventcontrollerscroll: Emit ::scroll for -1/+1 discrete steps

The > 1 meant it only emits the signal for -2/+2 steps.

8 years agotests: Add testgridbaseline
Timm Bäder [Wed, 11 Oct 2017 06:05:52 +0000 (08:05 +0200)]
tests: Add testgridbaseline

Which shows that GtkGrid currently computes baselines for all rows even
though not all of them might request a baseline.

8 years agocssnode: Delay getting the parent style until we need it
Timm Bäder [Tue, 10 Oct 2017 19:54:53 +0000 (21:54 +0200)]
cssnode: Delay getting the parent style until we need it

There's an early return before.

Look at all those saved cycles.

8 years agoDon't set child position in a ui file
Matthias Clasen [Tue, 10 Oct 2017 23:40:29 +0000 (19:40 -0400)]
Don't set child position in a ui file

It is not necessary, and causes assertions in some of
our tests.

8 years agocssnode: Don't put wrong styles in the style cache
Benjamin Otte [Tue, 10 Oct 2017 19:00:46 +0000 (21:00 +0200)]
cssnode: Don't put wrong styles in the style cache

~Company ╡ so TL;DR: we put the static style in the cache, but then
       ⤷ ╡ compute a child style from the animated style in the cache
       ⤷ ╡ and we put the child style also in the cache (because
       ⤷ ╡ it's not animated)
       ⤷ ╡ then we run the animation, but reuse the cache every time
       ⤷ ╡ for both child and parent
       ⤷ ╡ so after the animation is done, we end up with a cache that
       ⤷ ╡ has the correct static style for the parent but an
       ⤷ ╡ incorrect static style for the child
       ⤷ ╡ because that static style was computed from the
       ⤷ ╡ initial animated style

This fixes https://bugzilla.gnome.org/show_bug.cgi?id=763517

8 years agocssnodedeclaration: Add gtk_css_node_declaration_to_string
Timm Bäder [Tue, 10 Oct 2017 18:59:57 +0000 (20:59 +0200)]
cssnodedeclaration: Add gtk_css_node_declaration_to_string

8 years agobuild: Drop redundant workaround
Timm Bäder [Tue, 10 Oct 2017 10:53:06 +0000 (12:53 +0200)]
build: Drop redundant workaround

This is fixed and we require a meson > 0.39 anyway.

8 years agorendernode: Don't leak mem_surface
Timm Bäder [Tue, 10 Oct 2017 07:07:34 +0000 (09:07 +0200)]
rendernode: Don't leak mem_surface

8 years agoDon't try to snapshot invisible icons
Timm Bäder [Mon, 9 Oct 2017 15:38:54 +0000 (17:38 +0200)]
Don't try to snapshot invisible icons

These spew criticals when width == 0 || height == 0.

8 years agoscalebutton: Fix comparison for empty icon list
Timm Bäder [Sun, 8 Oct 2017 18:15:39 +0000 (20:15 +0200)]
scalebutton: Fix comparison for empty icon list

8 years agostylecontext: Fix doc comment
Timm Bäder [Sun, 8 Oct 2017 15:42:41 +0000 (17:42 +0200)]
stylecontext: Fix doc comment

There is no @cr here anymore.

8 years agoGdkDisplay: Add a private _emit_opened
Timm Bäder [Sun, 8 Oct 2017 15:38:38 +0000 (17:38 +0200)]
GdkDisplay: Add a private _emit_opened

So we don't have to use the slower g_signal_emit_by_name in startup
paths.

8 years agotextdisplay: Remove widgets parameter from gtk_text_layout_draw
Timm Bäder [Sun, 8 Oct 2017 08:49:28 +0000 (10:49 +0200)]
textdisplay: Remove widgets parameter from gtk_text_layout_draw

All calls in gtk+ were passing NULL anyway.

8 years agogrid: Drop priv pointer
Timm Bäder [Sun, 8 Oct 2017 08:40:48 +0000 (10:40 +0200)]
grid: Drop priv pointer

8 years agoReshuffle the css tests a bit
Matthias Clasen [Tue, 10 Oct 2017 04:18:21 +0000 (00:18 -0400)]
Reshuffle the css tests a bit

8 years agoReshuffle the a11y tests a bit
Matthias Clasen [Tue, 10 Oct 2017 04:16:10 +0000 (00:16 -0400)]
Reshuffle the a11y tests a bit

8 years agoAdd an install-tests option
Matthias Clasen [Tue, 10 Oct 2017 04:14:48 +0000 (00:14 -0400)]
Add an install-tests option

Use this to enable or disable installed tests.

8 years agoInstall css api test again
Matthias Clasen [Tue, 10 Oct 2017 03:35:19 +0000 (23:35 -0400)]
Install css api test again

8 years agoInstall css style tests again
Matthias Clasen [Tue, 10 Oct 2017 03:32:13 +0000 (23:32 -0400)]
Install css style tests again

Reinstate the installed tests for css style.

8 years agoInstall css parser tests again
Matthias Clasen [Tue, 10 Oct 2017 03:29:10 +0000 (23:29 -0400)]
Install css parser tests again

Reinstate the installed tests for the css parser.

8 years agoInstall css node tests again
Matthias Clasen [Tue, 10 Oct 2017 03:24:23 +0000 (23:24 -0400)]
Install css node tests again

Reinstate the installed tests for css nodes.

8 years agoFix docs build
Matthias Clasen [Tue, 10 Oct 2017 01:58:50 +0000 (21:58 -0400)]
Fix docs build

this include file can't be found, so just do without it.

8 years agoTowards a working docs build
Matthias Clasen [Mon, 9 Oct 2017 23:35:40 +0000 (19:35 -0400)]
Towards a working docs build

Add back images, content_files and expand_content files.

8 years agoUpdate Swedish translation
Anders Jonsson [Mon, 9 Oct 2017 23:19:22 +0000 (23:19 +0000)]
Update Swedish translation

8 years agoTowards a working docs build
Matthias Clasen [Mon, 9 Oct 2017 23:06:06 +0000 (19:06 -0400)]
Towards a working docs build

Pass mode: 'none' so escaping of <> in doc comments works.

8 years agoUpdated Czech translation
Marek Cernocky [Mon, 9 Oct 2017 19:32:02 +0000 (21:32 +0200)]
Updated Czech translation

8 years agoUpdated Slovenian translation
Matej Urbančič [Mon, 9 Oct 2017 18:54:24 +0000 (20:54 +0200)]
Updated Slovenian translation

8 years agoUpdate Polish translation
Piotr Drąg [Mon, 9 Oct 2017 18:42:22 +0000 (20:42 +0200)]
Update Polish translation

8 years agogdk: Translate some more key names
Piotr Drąg [Sat, 7 Oct 2017 23:05:22 +0000 (01:05 +0200)]
gdk: Translate some more key names

These are used in the Keyboard panel of GNOME Settings.

https://bugzilla.gnome.org/show_bug.cgi?id=787866

8 years agoprinting: Don't show duplicate printers
Marek Kasik [Wed, 30 Aug 2017 15:56:00 +0000 (17:56 +0200)]
printing: Don't show duplicate printers

Check UUID for printers obtained via DNSSD whether
they are already installed on local CUPS server.
Don't show such printers.

Not all printers published via DNSSD have UUID entry though.

https://bugzilla.gnome.org/show_bug.cgi?id=786794

8 years agoAdd a transform node reftest
Matthias Clasen [Mon, 9 Oct 2017 03:19:35 +0000 (23:19 -0400)]
Add a transform node reftest

8 years agoAdd another cross-fade reftest
Matthias Clasen [Mon, 9 Oct 2017 02:45:05 +0000 (22:45 -0400)]
Add another cross-fade reftest

8 years agosnapshot: Use a better placeholder
Matthias Clasen [Mon, 9 Oct 2017 02:19:22 +0000 (22:19 -0400)]
snapshot: Use a better placeholder

An empty container has the same effect as transparency
with the cairo renderer, but creates black with Vulkan.
To avoid this, explicitly use a transparent color node.

This fixes the css blendmode example in gtk4-demo with
the Vulkan renderer.

8 years agoRegenerate blendmodes reftest
Matthias Clasen [Mon, 9 Oct 2017 01:13:43 +0000 (21:13 -0400)]
Regenerate blendmodes reftest

8 years agoFix blendmode shader
Matthias Clasen [Mon, 9 Oct 2017 01:12:22 +0000 (21:12 -0400)]
Fix blendmode shader

My reading of the spec formulas was imperfect.

8 years agoRevise coordinate handling for blend nodes
Matthias Clasen [Mon, 9 Oct 2017 00:06:33 +0000 (20:06 -0400)]
Revise coordinate handling for blend nodes

This is the same change that was applied to cross-fade
nodes.

8 years agoStop using gsk_cairo_node_new_for_surface
Matthias Clasen [Mon, 9 Oct 2017 00:05:16 +0000 (20:05 -0400)]
Stop using gsk_cairo_node_new_for_surface

Best to avoid handling the surface ourselves.

8 years agoAdd another blendmodes reftest
Matthias Clasen [Sun, 8 Oct 2017 23:21:09 +0000 (19:21 -0400)]
Add another blendmodes reftest

This tests all blendmodes. Again, the Vulkan renderer fails.

8 years agoRevise the coordinate handling one more time
Matthias Clasen [Sun, 8 Oct 2017 22:36:57 +0000 (18:36 -0400)]
Revise the coordinate handling one more time

This makes the new reftests pass and hopefully does not
break other things.

8 years agoDialog: Clarify that response ID 0 is not reserved
Daniel Boles [Sun, 8 Oct 2017 21:19:13 +0000 (22:19 +0100)]
Dialog: Clarify that response ID 0 is not reserved

I only got so far in math, but it looks to me like zero isn’t positive.
We don’t reserve it, so be clear about that.

8 years agoMenuButton: Document the correct no-direction icon
Daniel Boles [Sun, 8 Oct 2017 20:07:55 +0000 (21:07 +0100)]
MenuButton: Document the correct no-direction icon

Document open-menu-symbolic, which we use, not view-context-menu, which
does not exist.

8 years agoAdd a cross-fade node ref test
Matthias Clasen [Sun, 8 Oct 2017 18:36:35 +0000 (14:36 -0400)]
Add a cross-fade node ref test

The Vulkan renderer doesn't pass this one either, currently.

8 years agoAdd a blendmode node reftest
Matthias Clasen [Sun, 8 Oct 2017 18:29:27 +0000 (14:29 -0400)]
Add a blendmode node reftest

The Vulkan renderer doesn't pass this, currently.

8 years agoFix application window snapshot differently
Matthias Clasen [Sun, 8 Oct 2017 18:03:19 +0000 (14:03 -0400)]
Fix application window snapshot differently

As Timm Baedert pointed out, the previous fix made the
menubar go on top of popovers, which is just wrong. Instead,
make gtk_window_snapshot handle all direct children of the
window, taking care to stack popovers correctly.

8 years agoExpand the repeat node test
Matthias Clasen [Sun, 8 Oct 2017 17:49:59 +0000 (13:49 -0400)]
Expand the repeat node test

Still not exhaustive, but enough to find some issues.

8 years agoAdd a repeat node test
Matthias Clasen [Sun, 8 Oct 2017 16:21:03 +0000 (12:21 -0400)]
Add a repeat node test

8 years agoAdd a basic cairo node test
Matthias Clasen [Sun, 8 Oct 2017 15:51:00 +0000 (11:51 -0400)]
Add a basic cairo node test

8 years agoAllow backend-specific reference images
Matthias Clasen [Sun, 8 Oct 2017 15:24:37 +0000 (11:24 -0400)]
Allow backend-specific reference images

This is not ideal, but lets us deal with differences for now.

8 years agovulkan: Fix cross-fade node coordinates
Matthias Clasen [Sun, 8 Oct 2017 15:26:53 +0000 (11:26 -0400)]
vulkan: Fix cross-fade node coordinates

This is the same fix as was just committed for blendmode nodes.

8 years agovulkan: Fix blendmode coordinate handling
Matthias Clasen [Sun, 8 Oct 2017 13:00:56 +0000 (09:00 -0400)]
vulkan: Fix blendmode coordinate handling

We were node handling coordinates correctly when dealing
with differently sized child nodes in a blendmode node.
This was showing up in the gtk4-demo css blendmode example,
for blendmodes other than normal.

8 years agovulkan: Fix repeat node coordinates
Matthias Clasen [Sun, 8 Oct 2017 12:44:02 +0000 (08:44 -0400)]
vulkan: Fix repeat node coordinates

We were not treating non-trivial child bounds right at all.
This was visible in the css blendmode cmyk example in gtk4-demo,
for the normal blendmode.

8 years agoinspector: Show child bounds for repeat nodes
Matthias Clasen [Sun, 8 Oct 2017 12:43:03 +0000 (08:43 -0400)]
inspector: Show child bounds for repeat nodes

The more information, the better.

8 years agoCreate tests for cairo node
Umang Jain [Fri, 6 Oct 2017 18:26:54 +0000 (23:56 +0530)]
Create tests for cairo node

https://bugzilla.gnome.org/show_bug.cgi?id=788534

8 years agogsk: Move gsk_cairo_node_new_for_surface into public API
Umang Jain [Fri, 6 Oct 2017 18:25:59 +0000 (23:55 +0530)]
gsk: Move gsk_cairo_node_new_for_surface into public API

https://bugzilla.gnome.org/show_bug.cgi?id=788534

8 years agogsk: Fix serialization of cairo node
Umang Jain [Wed, 4 Oct 2017 21:02:02 +0000 (02:32 +0530)]
gsk: Fix serialization of cairo node

https://bugzilla.gnome.org/show_bug.cgi?id=788534

8 years agotestmenubutton: Fix inverted keynav in the GtkMenu
Daniel Boles [Sun, 8 Oct 2017 12:15:33 +0000 (13:15 +0100)]
testmenubutton: Fix inverted keynav in the GtkMenu

GtkMenu’s own keynav code, which actually bothers to account for the
layout of items, only happens if columns > 1. So, adding items to 1
column using a reverse loop meant they were placed in the Menu’s list of
children in that order, and because we only have 1 column, Menu passes
keynav up to MenuShell, which doesn’t adjust for the items’ positions.

‘Fix’ that here by adding items in the same order they’ll have when laid
out in the Menu, so keynav does what you’d expect, not the opposite. For
that, it’s simpler just to use gtk_container_add().

Let’s presume users are using add(), attach() with a non-inverted loop,
or attach() with arguments that create 2+ columns and so GtkMenu keynav.

8 years agosnapshot: Set blend mode directly after pushing state
Timm Bäder [Sun, 8 Oct 2017 06:28:35 +0000 (08:28 +0200)]
snapshot: Set blend mode directly after pushing state

This is important since _push_state returns a pointer into a GArray
which could be invalidated and point to garbage after the subsequent
push_state call.

8 years agosnapshot: Fix blend mode handling
Matthias Clasen [Sun, 8 Oct 2017 03:31:47 +0000 (23:31 -0400)]
snapshot: Fix blend mode handling

We were getting out states confused and were always creating
a blend mode node with mode NORMAL.

8 years agogtk4-demo: fix a typo
Matthias Clasen [Sun, 8 Oct 2017 03:26:57 +0000 (23:26 -0400)]
gtk4-demo: fix a typo

The blend mode is called saturation, not saturate.

8 years agoAdwaita: theme the shortcuts window search results
Matthias Clasen [Sun, 8 Oct 2017 02:45:49 +0000 (22:45 -0400)]
Adwaita: theme the shortcuts window search results

Add some margins, and, since we can, also move the spacing here.

8 years agoShortcuts window: Make search results themable
Matthias Clasen [Sun, 8 Oct 2017 02:45:05 +0000 (22:45 -0400)]
Shortcuts window: Make search results themable

Add a style class to the box containing search results,
so we can apply style here.

8 years agoapplication window: Make menubar appear
Matthias Clasen [Sun, 8 Oct 2017 02:24:09 +0000 (22:24 -0400)]
application window: Make menubar appear

This needed to be ported to snapshot, still.

8 years agoAdwaita: theme shortcuts windows a bit
Matthias Clasen [Sun, 8 Oct 2017 00:13:13 +0000 (20:13 -0400)]
Adwaita: theme shortcuts windows a bit

Add some space around the content.

8 years agoshortcuts: Add css names to some widgets
Matthias Clasen [Sun, 8 Oct 2017 00:12:18 +0000 (20:12 -0400)]
shortcuts: Add css names to some widgets

This will let us put some styling in place for these.

8 years agogtk4-demo: Fix the scrollbar popup menu example
Matthias Clasen [Sat, 7 Oct 2017 23:54:47 +0000 (19:54 -0400)]
gtk4-demo: Fix the scrollbar popup menu example

A scrollbar is not a range anymore, so the callback
needs some adjustments (!).

8 years agoscrollbar: keep populate-popup signal working
Matthias Clasen [Sat, 7 Oct 2017 23:53:19 +0000 (19:53 -0400)]
scrollbar: keep populate-popup signal working

This is used for example in the source tab of gtk4-demo.
It broke because GtkScrollbar no longer is a GtkRange,
but rather has one. So we need to forward the signal.

8 years agonotebook: Don't steal right-clicks from content
Matthias Clasen [Sat, 7 Oct 2017 23:26:39 +0000 (19:26 -0400)]
notebook: Don't steal right-clicks from content

We only want to pop up the context menu in the tab strip.

8 years agoAdwaita: Fix scrollbar theming a bit
Matthias Clasen [Sat, 7 Oct 2017 23:10:58 +0000 (19:10 -0400)]
Adwaita: Fix scrollbar theming a bit

Reinstate the fine-tune mode scrollbars.

8 years agoscrollbar: Correct css docs
Matthias Clasen [Sat, 7 Oct 2017 23:10:10 +0000 (19:10 -0400)]
scrollbar: Correct css docs

The .fine-tune class appears on the range node.

8 years agoDrop the env var for scrolling control
Matthias Clasen [Sat, 7 Oct 2017 22:27:51 +0000 (18:27 -0400)]
Drop the env var for scrolling control

This was never meant to be an official api, but rather
a transition help. Time to drop it for GTK+ 4.

8 years agotextview: Fix memory handling
Matthias Clasen [Sat, 7 Oct 2017 03:06:52 +0000 (23:06 -0400)]
textview: Fix memory handling

When cleaning up the text appearance struct, we forgot
to add the new strikethrough_rgba member to the copy
function.

8 years agoprinting: Fix page drawing
Matthias Clasen [Sat, 7 Oct 2017 02:50:03 +0000 (22:50 -0400)]
printing: Fix page drawing

We were drawing frames around our drawing areas.

8 years agoprinting: Some fixes to the print dialog
Matthias Clasen [Sat, 7 Oct 2017 02:33:24 +0000 (22:33 -0400)]
printing: Some fixes to the print dialog

Hide widgets that are meant to be hidden initially, and use
the right spin button apis.

8 years agobutton: Fix label alignment in checks and radios
Matthias Clasen [Sat, 7 Oct 2017 02:32:53 +0000 (22:32 -0400)]
button: Fix label alignment in checks and radios

Yes, this is ugly, but the alternative is broken ui.

8 years agogtk-demo: Deal with big images
Matthias Clasen [Sat, 7 Oct 2017 01:59:34 +0000 (21:59 -0400)]
gtk-demo: Deal with big images

We don't want to grow our window to huge size just because
there is a big source image.

8 years agogtk-demo: Add a new overlay demo
Matthias Clasen [Sat, 7 Oct 2017 01:58:56 +0000 (21:58 -0400)]
gtk-demo: Add a new overlay demo

Replace the not very impressive transparent demo with
the blur-behind example.

8 years agogtk-demo: Fix the overlay demo
Matthias Clasen [Sat, 7 Oct 2017 01:35:21 +0000 (21:35 -0400)]
gtk-demo: Fix the overlay demo

We must make the label and the entry separate overlays, or
the entry will also be clickthru.

8 years agogtk-demo: Fix up the drawingarea example
Matthias Clasen [Sat, 7 Oct 2017 00:41:30 +0000 (20:41 -0400)]
gtk-demo: Fix up the drawingarea example

This was not working anymore.

8 years agogtk-demo: Make the color chooser example non-resizable
Matthias Clasen [Fri, 6 Oct 2017 23:48:03 +0000 (19:48 -0400)]
gtk-demo: Make the color chooser example non-resizable

No need for it.

8 years agoHC: Avoid inflated titlebar separator in GEdit etc
Daniel Boles [Sat, 7 Oct 2017 00:27:05 +0000 (01:27 +0100)]
HC: Avoid inflated titlebar separator in GEdit etc

It was selecting paned separator, which means any separator at any level
of descent within a paned, including the toplevel container in GEdit.

We need to be more specific and only select the relevant separator that
is the direct child of the paned. This is what Adwaita does.

https://bugzilla.gnome.org/show_bug.cgi?id=788573

8 years agoTreeViewCol: Fix SEGV on remove/add, + memory leak
Daniel Boles [Fri, 6 Oct 2017 19:24:49 +0000 (20:24 +0100)]
TreeViewCol: Fix SEGV on remove/add, + memory leak

Nulling priv->button in _unset_tree_view() is asymmetrical: we create
it via init(), not _set_tree_view(), so we shouldn’t null in the latter.

Worse, doing so manifests in criticals + a SEGV easily with basic use of
testtreecolumns, removing the TVC from a TV then trying to add it to one

Finally, the wrong null-out meant dispose() failed to unref the button,
so it leaked.

https://bugzilla.gnome.org/show_bug.cgi?id=728452
https://bugzilla.gnome.org/show_bug.cgi?id=788614

8 years agoTreeViewCol: Don’t try to disconnect null treeview
Daniel Boles [Fri, 6 Oct 2017 19:24:01 +0000 (20:24 +0100)]
TreeViewCol: Don’t try to disconnect null treeview

https://bugzilla.gnome.org/show_bug.cgi?id=788614

8 years agoRevert "treeviewcolumn: Don't leak button"
Daniel Boles [Fri, 6 Oct 2017 19:40:59 +0000 (20:40 +0100)]
Revert "treeviewcolumn: Don't leak button"

This reverts commit 2c28c627c1527d4ee2dfc4d3805f7afc482049e2.

See following commits: the real problem is setting priv->button to NULL
soon after this, so this just makes that wrong decision look more right.

https://bugzilla.gnome.org/show_bug.cgi?id=788614

8 years agoiconbrowser: Don’t repeat folder-download-symbolic
Daniel Boles [Fri, 6 Oct 2017 18:32:50 +0000 (19:32 +0100)]
iconbrowser: Don’t repeat folder-download-symbolic

It was in both [general] with a description and [other] with none.
Leave it in [other] with the other folder- icons, + the description.

bonus: this makes all of [general] fit in our default window size!

8 years agoFileChooserButton: Avoid unref()ing a null model
Daniel Boles [Fri, 6 Oct 2017 23:09:09 +0000 (00:09 +0100)]
FileChooserButton: Avoid unref()ing a null model

8 years agogtk-demo: Fix the assistant demo
Matthias Clasen [Fri, 6 Oct 2017 23:38:16 +0000 (19:38 -0400)]
gtk-demo: Fix the assistant demo

The progress bar was no longer expanding as intended,
due to the demise of GtkBox::expand.

8 years agosettings: Don't assert in notify
Matthias Clasen [Fri, 6 Oct 2017 23:30:27 +0000 (19:30 -0400)]
settings: Don't assert in notify

We can legitimately hit the default case in this switch,
so don't assert that we don't.